Fix previous exception rethrow on transaction rollback #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Dec 28, 2018
There was a problem hiding this comment.
Absolutely no-go.
As described in #7545 (comment), the exception coming from a failed rollback is indeed much more important here.
|
🤔 and how can ORM's user fix failing rollbacks then when it's impossible to find its origin? Only thing user knows is that rollback failed. Why, is a mystery. |
|
You can design an exception with two previous traces. See #6743 for examples on how we improved this for ORM 3.x. Right now, changing the exception type being thrown for a failed rollback would be a subtle BC break, so please look at that patch and propose a separate solution for 3.x, if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes" #7545
Not sure if proper fix, was checking DBAL's code and everything is IMO just fine there. So my goal was to keep both exceptions in ORM's code.
Or do you have ideas for a better way to fix?