Further exceptions tweaks #7210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @return PessimisticLockFailed | ||
| */ | ||
| public static function lockFailed() |
There was a problem hiding this comment.
Probably not in this PR, not directly related. :)
97477bd to
d7b4d39
Compare
d7b4d39 to
bb286d4
Compare
greg0ire
reviewed
May 2, 2018
| namespace Doctrine\ORM\Exception; | ||
|
|
||
| /** | ||
| * Exception for a unexpected query result. |
greg0ire
reviewed
May 2, 2018
| @@ -14,8 +14,10 @@ | |||
|
|
|||
| /** | |||
| * A MappingException indicates that something is wrong with the mapping setup. | |||
| * | |||
| * @todo Split into specific exceptions and change to interface. | |||
lcobucci
reviewed
May 2, 2018
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| /** | |||
| * Exception for a unexpected query result. | |||
| * | |||
| * @final | |||
There was a problem hiding this comment.
What's the reason for having this as an annotation?
5 tasks
malukenho
reviewed
May 5, 2018
| result contains more than one object, an ``NonUniqueResultException`` | ||
| is thrown. If the result contains no objects, an ``NoResultException`` | ||
| is thrown. The pure/mixed distinction does not apply. | ||
| result contains more than one object, an ``NonUniqueResult`` |
| is thrown. If the result contains no objects, an ``NoResultException`` | ||
| is thrown. The pure/mixed distinction does not apply. | ||
| result contains more than one object, an ``NonUniqueResult`` | ||
| is thrown. If the result contains no objects, an ``NoResult`` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands and refines #6743.
new().To be documented after first round of review.
cc @greg0ire
TODO: