[RFC] Expose QueryBuilder::getType

[VincentLanglet]

I have an implementation where I extends the QueryBuilder in order to provide extra methods.
In one of them, I'd like an easy way to know if the queryBuilder is creating a select, an update or a delete query.

I could extends select, addSelect, update and delete to keep a state with the type of the current query, but it seems like the QueryBuilder already does this. So I'd like to expose this information.

Are you okay with this ?

[derrabus]

Sounds reasonable to me. What do the others think?

[greg0ire]

Can you show us the piece of code where you need this, in case we can see another way?

[greg0ire]

Let's not open this too much, shall we?

Suggested change

	public function getType(): QueryType
	final protected function getType(): QueryType

[VincentLanglet]

Should I remove the test then ?

[greg0ire]

This is getting philosophical… I think protected method are part of the public API, so you should keep testing them. You could have

$qb = new class  extends QueryBuilder
{
    public method assertCallingUpdateMakesTheQueryAnUpdate(): void
    {
        $this->update();
        TestCase::assertSame(QueryType::UPDATE, $this->getType());
    }
}

$qb->assertCallingUpdateMakesTheQueryAnUpdate();

[VincentLanglet]

Can you show us the piece of code where you need this, in case we can see another way?

We have a method to batch Queries when the array of element is too big / the query too slow.
The implementation is basically this one.

chunkQueryAndExecute(string $parameterToChunk, int $chunkSize = 1000, int|string|null $hydrationMode = null)
{
     $parameter = $this->getParameter($parameterToChunk);
     $chunks = array_chunk($parameter->getValue(), $chunkSize, true);
     foreach ($chunks as $chunk) {
          $this->setParameter($parameterToChunk, $chunk);
          $result = $this->getQuery()->execute(null, $hydrationMode);
     }
}

Now I'd like to get the result.

• For select queries, we need to array merge all the results.
• For update/delete queries, we need to sum all the results.

Also, technically I should handle the case where $parameter->getValue() is an empty array and so without result, I cannot know if I need to return [] or 0.

I could use getDQLParts['select'] to check if there is some but

• I really feel hacky to play with DQLParts when there is an existing type.
• Technically, if I do $qb->select('foo')->delete() I think it will be a Type::Delete with a select dql part.

[greg0ire]

Please squash

[VincentLanglet]

Please squash

Sure, done

[greg0ire]

Thanks @VincentLanglet !