Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setAccessible() calls #10286

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Remove setAccessible() calls #10286

merged 1 commit into from
Dec 10, 2022

Conversation

derrabus
Copy link
Member

ReflectionProperty::setAccessible() and ReflectionMethod::setAccessible() are no-ops in PHP 8.1. Let's remove all calls.

@derrabus derrabus added this to the 3.0.0 milestone Dec 10, 2022
@derrabus derrabus merged commit 9d8cadf into doctrine:3.0.x Dec 10, 2022
@derrabus derrabus deleted the improvement/set-accessible branch December 10, 2022 22:18
@mpdude mpdude mentioned this pull request Jan 17, 2023
Merged
@mpdude mpdude mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabus @greg0ire