Convert @psalm-* annotations to generic or @phpstan-* annotation
#2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Oct 9, 2024
There was a problem hiding this comment.
There are a few instances of phpstan-return and phpstan-param that we could replace with the non-prefixed variants. Essentially, anytime we use a type defined using phpstan-type we need to use a phpstan prefix, for all other types we can skip the prefix. I'll let you decide whether you want to do this in this pull request or in a separate one.
As for the aggregation builder types, I believe the issue is that we have duplicate type declarations for Stage and Pipeline, which is responsible for the circular reference issues we've encountered before. We might want to revisit those as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@psalm-*to@phpstan-*non-empty-string,non-empty-arrayare supported by in PHPStorm.=in custom type definition$prefixed key in array-shape need quotes