Upgrade to psalm 5 #2504
Merged
Upgrade to psalm 5 #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Feb 20, 2023
composer.json
Outdated
| @@ -47,7 +47,7 @@ | |||
| "phpunit/phpunit": "^9.5.5", | |||
| "squizlabs/php_codesniffer": "^3.5", | |||
| "symfony/cache": "^4.4 || ^5.0 || ^6.0", | |||
| "vimeo/psalm": "^4.30.0" | |||
| "vimeo/psalm": "^5.6.0" | |||
There was a problem hiding this comment.
5.7 was released :D
Suggested change
| "vimeo/psalm": "^5.6.0" | |
| "vimeo/psalm": "^5.7.0" |
IonBazan
approved these changes
Feb 21, 2023
SenseException
approved these changes
Feb 22, 2023
0d3d2d0 to
4d29a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades to psalm 5, when doing that, it showed some issues, these are the most common ones:
this also will allow to install phpunit 10