Test against PHP 8.2 and MongoDB 6.0 #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
malarzm
commented
Dec 14, 2022
| Q | A |
|---|---|
| Type | task |
| BC Break | no |
| Fixed issues |
57cb0b4 to
9824ba6
Compare
9824ba6 to
4b0cb01
Compare
malarzm
commented
Dec 20, 2022
| - "5.0" | ||
| - "4.4" | ||
| - "4.2" | ||
| - "4.0" |
There was a problem hiding this comment.
4.0 has reached end of life in April 2022, no need to test against it. 4.2 will be gone in April 2023 by the way
malarzm
commented
Dec 20, 2022
| @@ -76,11 +77,6 @@ jobs: | |||
| - name: "Show driver information" | |||
| run: "php --ri mongodb" | |||
|
|
|||
| # Remove this when laminas/laminas-code 4.5 is released | |||
malarzm
commented
Dec 20, 2022
| @@ -278,34 +278,6 @@ public function testLookupStageReferenceManyStoreAsRef(): void | |||
| self::assertSame('malarzm', $result[1]['users'][0]['username']); | |||
| } | |||
|
|
|||
| public function testLookupStageReferenceManyWithoutUnwindMongoDB34(): void | |||
There was a problem hiding this comment.
This test started failing with MongoDB 6.0. Given is was written specifically for 3.4 it's ok to get rid of it
malarzm
commented
Dec 20, 2022
| @@ -44,7 +45,7 @@ public function testLoadingInvalidBackingValueThrowsError(): void | |||
| $this->dm->getDocumentCollection(Card::class)->insertOne($document); | |||
|
|
|||
| $this->expectException(ValueError::class); | |||
| $this->expectExceptionMessage(sprintf('"ABC" is not a valid backing value for enum "%s"', Suit::class)); | |||
| $this->expectExceptionMessageMatches(sprintf('/^"ABC" is not a valid backing value for enum "?%s"?$/', preg_quote(Suit::class))); | |||
malarzm
commented
Dec 20, 2022
| @@ -29,6 +29,7 @@ public function testTest(): void | |||
|
|
|||
| assert(isset($collection[0], $collection[1], $collection[2])); | |||
| // place element '0' after '1' | |||
| /** @var ArrayCollection<int, MODM29Embedded> $collection */ | |||
There was a problem hiding this comment.
This suddenly made Psalm fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.