Fix failing CI checks #2462
Merged
Fix failing CI checks #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ae9eb9 to
c0b0bd1
Compare
c0b0bd1 to
36827e4
Compare
malarzm
commented
Sep 20, 2022
| @@ -621,13 +621,15 @@ public function getReference(string $documentName, $identifier): object | |||
| /** @psalm-var ClassMetadata<T> $class */ | |||
| $class = $this->metadataFactory->getMetadataFor(ltrim($documentName, '\\')); | |||
| assert($class instanceof ClassMetadata); | |||
| /** @psalm-var T|false $document */ | |||
There was a problem hiding this comment.
Some of the changes I had to do look like a bug in Psalm. I'll try to pin them down in the meantime, figured green CI is more important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2452