Use colocated mapping driver #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
Mar 22, 2022
| */ | ||
| public function getReader() | ||
| { | ||
| Deprecation::trigger( |
There was a problem hiding this comment.
We're using trigger_deprecation in ODM
There was a problem hiding this comment.
🤦 thanks I forgot about that.
96fc723 to
73860a1
Compare
73860a1 to
06dbdb2
Compare
malarzm
approved these changes
Mar 22, 2022
|
Thanks @franmomu! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is based on doctrine/orm#9587 to allow #2419 and start decoupling from
doctrine/annotations.