Psalm level 5

[franmomu]

Q	A
Type	task
BC Break	no
Fixed issues

Summary

Replaces #2329

Since it's quite difficult and time consuming to fix all possible issues found by static analysis, I think it's better if we use a baseline to ignore some of the issues for now and we set a higher level so new code has to comply with that level.

I've targeted 2.3.x since there are some phpdoc fixed and it's not adding new features.

[malarzm]

Awesome 🎉

[malarzm]

null doesn't look like an acceptable value for the array but I guess it comes from convertXMLElementValue so let's live with that

[franmomu]

yep, exactly

[malarzm]

oh boy, now we're programming in comments :D

[franmomu]

😬 this can be really interesting when adding generics for example to Query, that depending on the hydrate value, maybe we change the return type of Query::execute() to just Iterator<TDocument> which would mean removing quite assert calls.

[malarzm]

These are not needed anymore or just problematic?

[franmomu]

This is interesting, we were getting:

ERROR: MoreSpecificImplementedParamType - lib/Doctrine/ODM/MongoDB/Proxy/Resolver/ProxyManagerClassNameResolver.php:37:45 - Argument 1 of Doctrine\ODM\MongoDB\Proxy\Resolver\ProxyManagerClassNameResolver::resolveClassName has the more specific type 'class-string<ProxyManager\Proxy\ProxyInterface<RealClassName>>|(class-string<RealClassName:fn-doctrine\odm\mongodb\proxy\resolver\proxymanagerclassnameresolver::resolveclassname as object>)', expecting 'class-string<Doctrine\Persistence\Proxy<T>>|(class-string<T:fn-doctrine\persistence\mapping\proxyclassnameresolver::resolveclassname as object>)' as defined by Doctrine\Persistence\Mapping\ProxyClassNameResolver::resolveClassName (see https://psalm.dev/140)
    public function resolveClassName(string $className): string

so I've removed it, but didn't pay attention that in doctrine/persistence, the interface is using Proxy:

<?php

namespace Doctrine\Persistence\Mapping;

use Doctrine\Persistence\Proxy;

interface ProxyClassNameResolver
{
    /**
     * @psalm-param class-string<Proxy<T>>|class-string<T> $className
     *
     * @psalm-return class-string<T>
     *
     * @template T of object
     */
    public function resolveClassName(string $className): string;
}

we are usingocramius/proxy-manager, so I'll leave it and ignore it since it adds the correct type.

[malarzm]

I think I've removed correct checks from the list of required ones, let's hope next PRs can be merged not only by me 👍