Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of unsupported Symfony versions #2380

Closed
wants to merge 1 commit into from

Conversation

franmomu
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues

Summary

Ref: #2375 (comment)

I've looked for: method_exists, interface_exists, symfony 3.4 and I haven't found anything, so I guess there are no BC layers.

@IonBazan
Copy link
Member

Initially I proposed that in #2375 but now when I think about it, ORM is supporting all versions from 3.0 to 6.0 without any maintenance overhead as Doctrine does not touch any Console nor VarDumper features that have changed recently. Since this is not a Symfony Bundle but a library, providing support for wide range of dependencies' versions is desired.

@franmomu
Copy link
Contributor Author

I'm fine with that. Checking this, I've realised that we are not testing those versions though.

phpbench/phpbench requires symfony/console ^4.2: https://github.com/phpbench/phpbench/blob/b1ea39a7a3cf996065638fd416f3653bcb5a5aa3/composer.json#L26

symfony/cache 4.4 requires symfony/var-dump ^4.2: https://github.com/symfony/cache/blob/8810b1addbd271245af891f5ffca90a5ab5eb8f2/composer.json#L31

@IonBazan
Copy link
Member

@franmomu should we use the vendor-bin plugin then? Or maybe try allowing super old versions of these tools like ORM did: https://github.com/doctrine/orm/blob/416aa1d2d71c8d1796781c3f57b17ba26debde26/composer.json#L41

@franmomu
Copy link
Contributor Author

In #2375 I've removed phpbench/phpbench when executing PHPUnit tests that allows to use Symfony 6 and console 3.4

@franmomu franmomu closed this Oct 22, 2021
@franmomu franmomu deleted the drop_versions branch October 22, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants