Allow ^6.0 for symfony/* #2370
Closed
Allow ^6.0 for symfony/* #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current workflows don't separate between the different Symfony versions. If a build installs a current Symfony 6 and fails, it would break a branch. Should this be addressed in this PR? |
|
Based on https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5966/files maybe we can do something like franmomu@564263c to test it |
|
I have started working on this recently but haven't quite managed to install Symfony 6 yet. For the time being, I decided to remove incompatible development tools (such as phpbench) when running tests, which I think is an acceptable compromise in order to test Symfony 6. For the current WIP state, see https://github.com/alcaeus/mongodb-odm/actions/runs/1236576935. |
|
Closing in favour of #2375. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows installation of upcoming 6.0 version of Symfony's components. Can't really make a test for them as phpbench/phpbench and psalm are in conflict, so let's home the community will let us know if anything is wrong. FWIW I tried running Symfony's
./vendor/bin/patch-type-declarations(https://wouterj.nl/2021/09/symfony-6-native-typing) for 5.4 and we're looking A-OK.