flip attribute driver constructor arguments #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80f4232 to
3557b96
Compare
3557b96 to
170caff
Compare
franmomu
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
I thought we had added the constructor in https://github.com/doctrine/mongodb-odm/pull/2344/files#r683695547
|
@franmomu You are right, I think I reverted that change at some point as I thought it is not necessary but when I was trying to use it in a Symfony app, it turned out that we have to keep the constructor this way, at least for now 🤷🏻♂️ |
|
Thanks @IonBazan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because
AbstractDoctrineExtensionexpects theAttributeDriverconstructor to accept$pathsas first argument, whileAnnotationDriverexpectsReaderto be passed there, we need to shift the argument order to make it compatible.https://github.com/symfony/symfony/blob/1d196159fde010590b857059b5219922031c284b/src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php#L209-L212
While ORM's
AttributeDriversimply skips that argument and does not allow to customize the reader, I decided to simply shift the argument order to maintain the compatibility withAbstractDoctrineExtensionand allow to customize the reader.