Improve phpdoc specification #2312

franmomu · 2021-05-22T15:53:24Z

These changes add more specific return type declaration as the ORM:

These changes fixes some issues on tests directory like:

Lines 27 to 29 in f225a0c

    
           $class = $this->factory->getMetadataFor(ShardedSubclass::class); 
        
           $this->assertTrue($class->isSharded());

isSharded is only available in ClassMetadata from this package or

Lines 31 to 33 in f225a0c

    
           $query = $this->dm->getRepository(User::class) 
        
               ->createQueryBuilder() 
        
               ->getQuery();

createQueryBuilder not available in ObjectRepository but DocumentRepository.

alcaeus · 2021-05-31T08:27:35Z

franmomu force-pushed the improve_phpdoc branch from ef22ee4 to 58870c3 Compare May 22, 2021 20:23

Improve phpdoc return type

a226867

franmomu force-pushed the improve_phpdoc branch from 58870c3 to a226867 Compare May 22, 2021 20:29

alcaeus approved these changes May 31, 2021

View reviewed changes

alcaeus added the Documentation label May 31, 2021

alcaeus self-assigned this May 31, 2021

alcaeus added this to the 2.3.0 milestone May 31, 2021

alcaeus merged commit 993288d into doctrine:2.3.x May 31, 2021

franmomu deleted the improve_phpdoc branch May 31, 2021 08:33

alcaeus modified the milestones: 2.3.0-alpha1, 2.3.0 Sep 9, 2021

Provide feedback

	$class = $this->factory->getMetadataFor(ShardedSubclass::class);

	$this->assertTrue($class->isSharded());

	$query = $this->dm->getRepository(User::class)
	->createQueryBuilder()
	->getQuery();