Fix preparation of $elemMatch operators in queries #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
approved these changes
Mar 31, 2021
| class GH2251Test extends BaseTest | ||
| { | ||
| /** | ||
| * @testWith ["groups"] |
There was a problem hiding this comment.
This is a variant of data providers that doesn't require an extra method. It's useful when passing scalar values and reduces the test overhead.
alcaeus
added a commit
that referenced
this pull request
May 21, 2021
* Fix locking when ClassMetadata is unserialized Caching / unserializing ClassMetadata broke locking functionality Fixes #2278 * Test serialization of lock/version fields * Update working-with-objects.rst Detach doc text from code block * Update storage-strategies.rst * Fix invalid strict comparison when validating mappings * Correctly handle write concern specified in defaultCommitOptions (#2294) * Fix documentation for uploadFromFile * Fix mapping of the nullable option for XML driver * Fix query preparation when in elemMatch (#2299) * Fix preparation of $elemMatch operators in queries (#2298) * Fix using null values in partial filter expressions (#2300) * Fix errors with nullable typed associations (#2302) * Fix initialising nullable associations * Fix error when merging documents with uninitialised typed properties Co-authored-by: buffcode <buffcode@users.noreply.github.com> Co-authored-by: Laurens Stötzel <l.stoetzel@meeva.de> Co-authored-by: Maciej Malarz <malarzm@gmail.com> Co-authored-by: jeeiex <78592605+jeeiex@users.noreply.github.com> Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com> Co-authored-by: Andreas Braun <git@alcaeus.org> Co-authored-by: Gocha Ossinkine <ossinkine@ya.ru> Co-authored-by: Ryan RAJKOMAR <rrajkomar@users.noreply.github.com> Co-authored-by: wuchen90 <wu.chen@agriconomie.com> Co-authored-by: Andreas Braun <alcaeus@users.noreply.github.com>
alcaeus
added a commit
to alcaeus/mongodb-odm
that referenced
this pull request
Jun 29, 2021
* 2.2.x: Fix handling of upserts during scheduling for deletion (doctrine#2334) Fix wrong handling for nullable fields in upsert and update (doctrine#2318) [2.2] Fix builds (doctrine#2319) Allow mixed value in $not operator (doctrine#2307) Fix errors with nullable typed associations (doctrine#2302) Fix using null values in partial filter expressions (doctrine#2300) Fix preparation of $elemMatch operators in queries (doctrine#2298) Fix query preparation when in elemMatch (doctrine#2299) Fix mapping of the nullable option for XML driver Fix documentation for uploadFromFile Correctly handle write concern specified in defaultCommitOptions (doctrine#2294) Fix invalid strict comparison when validating mappings Update storage-strategies.rst Update working-with-objects.rst Test serialization of lock/version fields Fix locking when ClassMetadata is unserialized
alcaeus
added a commit
to alcaeus/mongodb-odm
that referenced
this pull request
Jun 29, 2021
* 2.2.x: Fix handling of upserts during scheduling for deletion (doctrine#2334) Fix wrong handling for nullable fields in upsert and update (doctrine#2318) [2.2] Fix builds (doctrine#2319) Allow mixed value in $not operator (doctrine#2307) Fix errors with nullable typed associations (doctrine#2302) Fix using null values in partial filter expressions (doctrine#2300) Fix preparation of $elemMatch operators in queries (doctrine#2298) Fix query preparation when in elemMatch (doctrine#2299) Fix mapping of the nullable option for XML driver Fix documentation for uploadFromFile Correctly handle write concern specified in defaultCommitOptions (doctrine#2294) Fix invalid strict comparison when validating mappings Update storage-strategies.rst Update working-with-objects.rst Test serialization of lock/version fields Fix locking when ClassMetadata is unserialized
alcaeus
added a commit
to alcaeus/mongodb-odm
that referenced
this pull request
Jun 29, 2021
* 2.2.x: Fix handling of upserts during scheduling for deletion (doctrine#2334) Fix wrong handling for nullable fields in upsert and update (doctrine#2318) [2.2] Fix builds (doctrine#2319) Allow mixed value in $not operator (doctrine#2307) Fix errors with nullable typed associations (doctrine#2302) Fix using null values in partial filter expressions (doctrine#2300) Fix preparation of $elemMatch operators in queries (doctrine#2298) Fix query preparation when in elemMatch (doctrine#2299) Fix mapping of the nullable option for XML driver Fix documentation for uploadFromFile Correctly handle write concern specified in defaultCommitOptions (doctrine#2294) Fix invalid strict comparison when validating mappings Update storage-strategies.rst Update working-with-objects.rst Test serialization of lock/version fields Fix locking when ClassMetadata is unserialized
alcaeus
added a commit
to alcaeus/mongodb-odm
that referenced
this pull request
Jun 29, 2021
* 2.2.x: Fix handling of upserts during scheduling for deletion (doctrine#2334) Fix wrong handling for nullable fields in upsert and update (doctrine#2318) [2.2] Fix builds (doctrine#2319) Allow mixed value in $not operator (doctrine#2307) Fix errors with nullable typed associations (doctrine#2302) Fix using null values in partial filter expressions (doctrine#2300) Fix preparation of $elemMatch operators in queries (doctrine#2298) Fix query preparation when in elemMatch (doctrine#2299) Fix mapping of the nullable option for XML driver Fix documentation for uploadFromFile Correctly handle write concern specified in defaultCommitOptions (doctrine#2294) Fix invalid strict comparison when validating mappings Update storage-strategies.rst Update working-with-objects.rst Test serialization of lock/version fields Fix locking when ClassMetadata is unserialized
alcaeus
added a commit
to alcaeus/mongodb-odm
that referenced
this pull request
Aug 2, 2021
* 2.2.x: Fix wrong assertion (doctrine#2335) Fix handling of upserts during scheduling for deletion (doctrine#2334) Fix wrong handling for nullable fields in upsert and update (doctrine#2318) [2.2] Fix builds (doctrine#2319) Allow mixed value in $not operator (doctrine#2307) Fix errors with nullable typed associations (doctrine#2302) Fix using null values in partial filter expressions (doctrine#2300) Fix preparation of $elemMatch operators in queries (doctrine#2298) Fix query preparation when in elemMatch (doctrine#2299) Fix mapping of the nullable option for XML driver Fix documentation for uploadFromFile Correctly handle write concern specified in defaultCommitOptions (doctrine#2294) Fix invalid strict comparison when validating mappings Update storage-strategies.rst Update working-with-objects.rst Test serialization of lock/version fields Fix locking when ClassMetadata is unserialized
alcaeus
added a commit
that referenced
this pull request
Aug 5, 2021
* Fix locking when ClassMetadata is unserialized Caching / unserializing ClassMetadata broke locking functionality Fixes #2278 * Test serialization of lock/version fields * Update working-with-objects.rst Detach doc text from code block * Update storage-strategies.rst * Fix invalid strict comparison when validating mappings * Correctly handle write concern specified in defaultCommitOptions (#2294) * Fix documentation for uploadFromFile * Fix mapping of the nullable option for XML driver * Fix query preparation when in elemMatch (#2299) * Fix preparation of $elemMatch operators in queries (#2298) * Fix using null values in partial filter expressions (#2300) * Fix errors with nullable typed associations (#2302) * Fix initialising nullable associations * Fix error when merging documents with uninitialised typed properties * Allow mixed value in $not operator (#2307) * [2.2] Fix builds (#2319) * Fix wrong handling for nullable fields in upsert and update (#2318) * Comprehensively test nullable behaviour for embedOne Co-authored-by: wuchen90 <wu.chen@agriconomie.com> * Fix handling of nullable fields for upsert Co-authored-by: wuchen90 <wu.chen@agriconomie.com> * Fix handling of upserts during scheduling for deletion (#2334) * Fix handling of upserts during scheduling for deletion * Added test * Fix wrong assertion (#2335) This was uncovered by Psalm testing when merging 2.2.x up into 2.3.x. * Remove psalm-baseline.xml Co-authored-by: buffcode <buffcode@users.noreply.github.com> Co-authored-by: Laurens Stötzel <l.stoetzel@meeva.de> Co-authored-by: Maciej Malarz <malarzm@gmail.com> Co-authored-by: jeeiex <78592605+jeeiex@users.noreply.github.com> Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com> Co-authored-by: Gocha Ossinkine <ossinkine@ya.ru> Co-authored-by: Ryan RAJKOMAR <rrajkomar@users.noreply.github.com> Co-authored-by: wuchen90 <wu.chen@agriconomie.com> Co-authored-by: Fran Moreno <franmomu@gmail.com> Co-authored-by: Bernhard Schussek <bschussek@gmail.com>
alcaeus
added a commit
that referenced
this pull request
Aug 5, 2021
* 2.2.x: Fix wrong assertion (#2335) Fix handling of upserts during scheduling for deletion (#2334) Fix wrong handling for nullable fields in upsert and update (#2318) [2.2] Fix builds (#2319) Allow mixed value in $not operator (#2307) Fix errors with nullable typed associations (#2302) Fix using null values in partial filter expressions (#2300) Fix preparation of $elemMatch operators in queries (#2298) Fix query preparation when in elemMatch (#2299) Fix mapping of the nullable option for XML driver Fix documentation for uploadFromFile Correctly handle write concern specified in defaultCommitOptions (#2294) Fix invalid strict comparison when validating mappings Update storage-strategies.rst Update working-with-objects.rst Test serialization of lock/version fields Fix locking when ClassMetadata is unserialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contrary to the suggestion in #2251 (comment), the solution is to give
$elemMatchthe same treatment as$notand recurse the query preparation.