Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doctrine/coding-standard #2269

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Update doctrine/coding-standard #2269

merged 3 commits into from
Jan 13, 2021

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Jan 11, 2021

Q A
Type improvement
BC Break no
Fixed issues n/a

@malarzm malarzm force-pushed the cs-standard-8 branch 2 times, most recently from feecdb9 to af0c87c Compare January 11, 2021 21:50
@malarzm malarzm marked this pull request as ready for review January 11, 2021 22:02
@malarzm
Copy link
Member Author

malarzm commented Jan 11, 2021

@alcaeus if you prefer I may remove all the whitespace changes to a separate PR (sadly I thought about this too late in the progress)

@malarzm malarzm added the Task label Jan 11, 2021
@malarzm malarzm added this to the 2.2.0 milestone Jan 11, 2021
@alcaeus
Copy link
Member

alcaeus commented Jan 12, 2021

@alcaeus if you prefer I may remove all the whitespace changes to a separate PR (sadly I thought about this too late in the progress)

Assuming the changes were made by running vendor/bin/phpcbf, I'm not going to review this PR beyond the phpcs.xml file ;)

@malarzm
Copy link
Member Author

malarzm commented Jan 12, 2021

Ok I'll need to split it then as there were few manual changes

@alcaeus
Copy link
Member

alcaeus commented Jan 12, 2021

Separate commits will do 😊

alcaeus
alcaeus approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in src look good, didn't bother with tests.

@malarzm malarzm merged commit e971729 into doctrine:master Jan 13, 2021
@malarzm malarzm deleted the cs-standard-8 branch January 13, 2021 13:39
@malarzm
Copy link
Member Author

malarzm commented Jan 13, 2021

Thanks! I'll be making follow-up PRs prolly today

@malarzm malarzm mentioned this pull request Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@malarzm @alcaeus