Added missing check for order of compound keys #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Grabenstein <christoph.grabenstein@sensiolabs.de>
alcaeus
approved these changes
Dec 8, 2020
malarzm
reviewed
Dec 9, 2020
|
|
||
| private function hasTextIndexesAtSamePosition(IndexInfo $mongoIndex, array $documentIndex) : bool | ||
| { | ||
| $mongoIndexKeys = $mongoIndex['key']; |
There was a problem hiding this comment.
Personally I'd prefer $mongoIndex->getKey() but as we're dealing with array structures here anyway that's a nitpick
There was a problem hiding this comment.
Ah, I missed this. While we do implement ArrayAccess for IndexInfo, I believe it's more sensible to rely on the public API of the class over accessing data as array elements. However, since I'm not sure where we're still doing this we may want to do a separate PR to fix this.
|
Thanks a a lot @cgrabenstein for providing the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Grabenstein christoph.grabenstein@sensiolabs.de
Summary
The fix consist of two main changes:
array_keys of the index-key-arrays.