[1.3] Optimize nested collection deletions #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02ecb89 to
9101c91
Compare
malarzm
reviewed
Feb 6, 2019
| ## Persisters | ||
|
|
||
| * The `delete` and `update` methods in | ||
| `Doctrine\ODM\MongoDB\Persisters\CollectionPersister` are deprecated. Use |
There was a problem hiding this comment.
"are" here should likely change but I'm leaving this for a future proofreading :)
malarzm
approved these changes
Feb 6, 2019
|
@alcaeus feel free to merge once the conflict is resolved |
…letion of collections that is belong to one document.
…sister::deleteAll. Fixed style of code.
…eduled for update - now nested collections for one parent is updated inside one query where it was possible.
…queries where it is required. Added missing tests for checking simultaneous embed-many collections updates under different storage strategies.
9101c91 to
f122613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This back ports #1880 to the 1.3 branch, deprecating the current method signatures of
deleteandupdatein the process.