Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace string assertion with array assertion for $filter #1944

Merged

Conversation

thiver
Copy link
Contributor

@thiver thiver commented Jan 24, 2019

Q A
Type bug
BC Break no
Fixed issues #1943

Summary

The $filter input option from the generate commands should be asserted as array instead of string.

@malarzm malarzm added this to the 2.0.0-Beta2 milestone Jan 24, 2019
@malarzm malarzm added the Bug label Jan 24, 2019
@malarzm
Copy link
Member

malarzm commented Jan 24, 2019

@thiver thanks for the fix! Could you please squash your commits or do you prefer us doing so?

fix: function imports

fix: import sort order
@thiver thiver force-pushed the fix/generate-commands-assert branch from 7aae405 to 41de69b Compare January 24, 2019 11:12
@malarzm
Copy link
Member

malarzm commented Jan 24, 2019

Thanks a lot @thiver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants