Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect schema commands behaviour #1918

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Fix incorrect schema commands behaviour #1918

merged 2 commits into from
Jan 3, 2019

Conversation

Rybbow
Copy link
Contributor

@Rybbow Rybbow commented Jan 3, 2019

Q A
Type bug
BC Break no
Fixed issues #1916

Summary

Fixes for broken schema commands, that did not use parent::configure() call, which is needed to steup all command options. Changed also ShardCommand and SchemaManager to allow using writeConcern when sharding.

@Rybbow Rybbow mentioned this pull request Jan 3, 2019
Closed
@alcaeus alcaeus self-requested a review January 3, 2019 11:36
alcaeus
alcaeus approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rybbow!

@alcaeus alcaeus added the Bug label Jan 3, 2019
@alcaeus alcaeus self-assigned this Jan 3, 2019
@alcaeus alcaeus added this to the 2.0.0-Beta2 milestone Jan 3, 2019
@alcaeus alcaeus merged commit d69a4fe into doctrine:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
BC Break Bug
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@Rybbow @alcaeus