-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid mapping class by more than one AbstractDocument #1906
Conversation
malarzm
commented
Nov 28, 2018
Q | A |
---|---|
Type | improvement |
BC Break | yes |
Fixed issues | n/a |
public static function classCanOnlyBeMappedByOneAbstractDocument(string $className, AbstractDocument $mappedAs, AbstractDocument $offending) : self | ||
{ | ||
return new self(sprintf( | ||
"Can not map class '%s' as %s because it was already mapped as %s.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I omitted "a/an" before "%s" on purpose to not deal with "an EmbeddedDocument"/"a (everything else)" ;)
274dfb2
to
9f4f088
Compare
tests/Doctrine/ODM/MongoDB/Tests/Mapping/AnnotationDriverTest.php
Outdated
Show resolved
Hide resolved
9f4f088
to
10341e1
Compare
One last thing, can you add a note to the |
10341e1
to
f08a708
Compare
Here you go. I'm not sure about the wording though. |
Thanks @malarzm! |