Optimized nested collections deletion in DocumentPersister #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letion of collections that is belong to one document.
malarzm
reviewed
Oct 19, 2018
| $user = $this->getTestUser('jwage'); | ||
|
|
||
| $persister->deleteAll( | ||
| [$user->categories[0]->children[0]->children, $user->categories[0]->children[1]->children], |
There was a problem hiding this comment.
What would happen if the method is called with [$user->categories[0]->children[0]->children, $user->categories ?
There was a problem hiding this comment.
Added filter for excluding of all sub-paths from the paths set.
Changes cant be found in PR to the master
…sister::deleteAll. Fixed style of code.
|
Close this PR to |
|
Close this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented CollectionPersister::deleteAll method for simultaneous deletion of collections that is belong to one document.
Summary
Improved removal of scheduled for removal collections. Now all collections that is belong to one parent is deleted in one query.