Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Require php : ^7.2 #1844

Merged
merged 1 commit into from
Aug 6, 2018
Merged

[2.0] Require php : ^7.2 #1844

merged 1 commit into from
Aug 6, 2018

Conversation

caciobanu
Copy link
Contributor

Q A
Type improvement
BC Break yes
Fixed issues #1704

alcaeus
alcaeus approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay - now to start adding object type hints ;)

@alcaeus alcaeus added this to the 2.0.0 milestone Aug 6, 2018
@malarzm
Copy link
Member

malarzm commented Aug 6, 2018

@caciobanu mind resolving conflict and rebasing atop current master?

@caciobanu
Copy link
Contributor Author

@malarzm done.

@malarzm malarzm added the Task label Aug 6, 2018
@malarzm malarzm merged commit 215e5e6 into doctrine:master Aug 6, 2018
@malarzm
Copy link
Member

malarzm commented Aug 6, 2018

Thanks @caciobanu 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@caciobanu @malarzm @alcaeus