Stop ignoring ControlStructures.EarlyExit #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
commented
Mar 15, 2018
| } elseif ($lower === 'desc') { | ||
| } | ||
|
|
||
| if ($lower === 'desc') { |
There was a problem hiding this comment.
I'm not sure why it was caught (unless elseif is a bad practice), there's also one more such change. Should I revert?
There was a problem hiding this comment.
That looks like a bug. We should change them back and report it upstream.
alcaeus
approved these changes
Mar 16, 2018
This was referenced Mar 16, 2018
6569ad6 to
5edd61b
Compare
Majkl578
reviewed
Mar 22, 2018
| @@ -1703,9 +1709,11 @@ public function setParentClasses(array $classNames) | |||
| { | |||
| $this->parentClasses = $classNames; | |||
|
|
|||
| if (count($classNames) > 0) { | |||
| $this->rootDocumentName = array_pop($classNames); | |||
| if (count($classNames) <= 0) { | |||
There was a problem hiding this comment.
This can never be <0, but I understand how this happened. :D
There was a problem hiding this comment.
Better safe than sorry... or something :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic fixes