Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Remove slaveOkay remainders #1716

Merged
merged 1 commit into from
Jan 9, 2018
Merged

[2.0] Remove slaveOkay remainders #1716

merged 1 commit into from
Jan 9, 2018

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Jan 7, 2018

Resurrection of #1673, removes stuff that lived through driver change

@malarzm malarzm added this to the 2.0.0 milestone Jan 7, 2018
@malarzm malarzm requested a review from alcaeus January 7, 2018 19:58
alcaeus
alcaeus approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dangit, that must've gotten lost somewhere 😞

Thanks for removing it!

@malarzm malarzm merged commit df01cfa into doctrine:master Jan 9, 2018
@malarzm malarzm deleted the remove-slave-okay-again branch January 9, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
BC Break Task
Projects
None yet
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@malarzm @alcaeus