Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Remove deprecated annotations #1471

Merged
merged 4 commits into from
Jan 15, 2017
Merged

[2.0] Remove deprecated annotations #1471

merged 4 commits into from
Jan 15, 2017

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Jul 30, 2016 •
edited
Loading

@malarzm malarzm added the Task label Jul 30, 2016
@malarzm malarzm added this to the 2.0.0 milestone Jul 30, 2016
This was referenced Jul 30, 2016
Closed
Merged
@alcaeus
Copy link
Member

alcaeus commented Jul 31, 2016

do we still need DoctrineAnnotations.php?

Not sure, but at least the Bundle seems to load the annotations automatically. Personally I'd prefer if we could do without.

@malarzm malarzm mentioned this pull request Jul 31, 2016
Merged
@malarzm malarzm force-pushed the remove-annotations branch 2 times, most recently from 020f148 to 5b0b84a Compare January 14, 2017 19:15
@malarzm malarzm requested a review from alcaeus January 14, 2017 19:44
alcaeus
alcaeus approved these changes Jan 15, 2017
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the indentation, looks good! 👍

docs/en/tutorials/getting-started.rst
@@ -6,8 +6,8 @@ domain model in a non-interfering way. Non-relational or no-sql
databases like MongoDB give you flexibility of building data store
around your object model and not vise versa. You can read more on the
initial configuration and setup in :doc:`Introduction to MongoDB Object
Document Mapper <../reference/introduction>`. This section will give you a basic
overview of what could be accomplished using Doctrine MongoDB ODM.
Document Mapper <../reference/introduction>`. This section will give you a basic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing seems off here.

@malarzm malarzm force-pushed the remove-annotations branch from 5b0b84a to 3f8fba8 Compare January 15, 2017 10:03
@malarzm malarzm force-pushed the remove-annotations branch from 3f8fba8 to 580eced Compare January 15, 2017 10:50
@malarzm malarzm merged commit 7fc8da8 into doctrine:odm-ng Jan 15, 2017
@malarzm malarzm deleted the remove-annotations branch January 15, 2017 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@malarzm @alcaeus