Cannot override the class metadata factory via configuration since 2.5.0

[alekitto]

BC Break Report

Q	A
BC Break	yes
Version	2.5.0

Summary

Since version 2.5.0, the class metadata factory cannot be overridden.

Previous behavior

The document manager has been instantiated taking the class name from the configuration on document manager construction

Current behavior

Since 5987555 the override is broken as the document manager is wired to the final class Doctrine\ODM\MongoDB\Mapping\ClassMetadataFactory.
To allow overriding via configuration, it should be wired against Doctrine\Persistence\Mapping\ClassMetadataFactory interface.

How to reproduce

$config = new Configuration();
$config->setClassMetadataFactoryName(FakeMetadataFactory::class);
DocumentManager::create(config: $config);

[malarzm]

This one's more tricky because of the initialization step

mongodb-odm/lib/Doctrine/ODM/MongoDB/DocumentManager.php

Lines 158 to 160 in 9b7ed61

	$this->metadataFactory = new $metadataFactoryClassName();
	$this->metadataFactory->setDocumentManager($this);
	$this->metadataFactory->setConfiguration($this->config);

for which Persistence's interface is not sufficient. Most probably we should introduce our own interface.

Offhand, what's your use case for custom metadata factory?

[alekitto]

Most probably we should introduce our own interface.

Agree

Offhand, what's your use case for custom metadata factory?

It is mostly used for testing actually: I'm using a DocumentManager with a mocked connection and a custom metadata factory in order to precisely control what is returned from the factory itself

[malarzm]

Closing as #2552 got merged