Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Update docs for strict typing #1783

Closed
alcaeus opened this issue Apr 12, 2018 · 0 comments
Closed

[2.0] Update docs for strict typing #1783

alcaeus opened this issue Apr 12, 2018 · 0 comments
Labels
Documentation Hacktoberfest Good issue for participating in Hacktoberfest
Milestone
2.0.0-Beta1

Comments

@alcaeus
Copy link
Member

alcaeus commented Apr 12, 2018

In response to #1774, we should update the code samples in our documentation to use strict typing. We definitely need to do this for ODM 2.0 (which is PHP 7.1+ only), but it may be worth backporting to 1.2.
@alcaeus alcaeus added this to the 2.0.0 milestone Apr 12, 2018
@alcaeus alcaeus mentioned this issue Apr 12, 2018
Closed
@caciobanu caciobanu mentioned this issue Apr 12, 2018
Merged
@malarzm malarzm added the Hacktoberfest Good issue for participating in Hacktoberfest label Oct 2, 2018
@watari watari mentioned this issue Oct 23, 2018
Merged
alcaeus added a commit that referenced this issue Oct 24, 2018
@alcaeus
Merge pull request #1883 from watari/issue_1783
757fd86 
Added more strict types for docs (Issue #1783)
@alcaeus alcaeus closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Hacktoberfest Good issue for participating in Hacktoberfest
Projects
None yet
Milestone
2.0.0-Beta1
Development

No branches or pull requests
2 participants
@alcaeus @malarzm