Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBAL-1302 Avoid rewrapping Docrine\DBAL\Exception\DriverException with nested drivers #923

Merged
merged 1 commit into from
Dec 14, 2015
Merged

DBAL-1302 Avoid rewrapping Docrine\DBAL\Exception\DriverException with nested drivers #923

merged 1 commit into from
Dec 14, 2015

Conversation

mathroc
Copy link
Contributor

@mathroc mathroc commented Nov 21, 2015

fixes DBAL-1302

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1782

We use Jira to track the state of pull requests and the versions they got
included in.

@doctrinebot doctrinebot mentioned this pull request Dec 6, 2015
Closed
@deeky666
Copy link
Member

@mathroc basically this looks good to me. Can you please provide test cases for the changes?

@deeky666 deeky666 self-assigned this Dec 11, 2015
@mathroc mathroc force-pushed the avoid-over-nesting-exceptions branch 6 times, most recently from 3065c79 to ca81434 Compare December 13, 2015 10:54
@mathroc mathroc force-pushed the avoid-over-nesting-exceptions branch from ca81434 to 8a3a81f Compare December 13, 2015 10:57
@mathroc
Copy link
Contributor Author

mathroc commented Dec 13, 2015

thx @deeky666 I added a test and refactored it a bit

deeky666 added a commit that referenced this pull request Dec 14, 2015
@deeky666
Merge pull request #923 from mathroc/avoid-over-nesting-exceptions
069280e 
Avoid rewrapping Docrine\DBAL\Exception\DriverException with nested drivers
@deeky666 deeky666 merged commit 069280e into doctrine:master Dec 14, 2015
@deeky666
Copy link
Member

@mathroc thanks!

@deeky666 deeky666 added this to the 2.6 milestone Dec 14, 2015
@Ocramius Ocramius changed the title Avoid rewrapping Docrine\DBAL\Exception\DriverException with nested drivers Avoid rewrapping Docrine\DBAL\Exception\DriverException with nested drivers Jul 22, 2017
@Ocramius Ocramius changed the title Avoid rewrapping Docrine\DBAL\Exception\DriverException with nested drivers DBAL-1302 Avoid rewrapping Docrine\DBAL\Exception\DriverException with nested drivers Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@deeky666 deeky666

Labels
Drivers Error Handling Improvement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mathroc @doctrinebot @deeky666 @Ocramius