Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url resolution for master/slave connections #3246

Conversation

deguif
Copy link

@deguif deguif commented Aug 9, 2018

Q A
Type bug
BC Break no
Fixed issues

Summary

When using url option for configuring master/slave connection, the url is never parsed and the connection parameters are not filled as they should.

@deguif deguif force-pushed the fix-url-resolution-for-slave-master-connection branch from 41f3c04 to d4d6ea3 Compare August 9, 2018 17:27
@deguif
Copy link
Author

deguif commented Aug 9, 2018

Just see that it was already proposed by @stof in #3201
By the way his implementation supports also sharding and is tested, so this one can be closed.

@Majkl578
Copy link
Contributor

Duplicate of #3201

@Majkl578 Majkl578 marked this as a duplicate of #3201 Aug 18, 2018
@Majkl578
Copy link
Contributor

Closing as per @deguif's comment above.

@Majkl578 Majkl578 closed this Aug 18, 2018
@Majkl578 Majkl578 self-assigned this Aug 18, 2018
@deguif deguif deleted the fix-url-resolution-for-slave-master-connection branch August 20, 2018 07:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants