DateIntervalType (negative support) resolves doctrine/dbal#2578 #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EHER
commented
Jun 30, 2017
- PR DateIntervalType (negative support) resolves doctrine/dbal#2578 #2579 from @galeaspablo using suggestion from comments to support old DateInterval format.
|
Is there any need to support the old format? BC doesn't matter inside dev branch. |
It does matter, |
|
The old format was introduced inside 2.6 dev. If it was in 2.5, it would be a new type. I.e. backwards compatibility of something that was introduced in the same dev branch doesn't matter. |
|
Please also refer to #2578 (comment) This is not a backwards compatibility break. Also, please note that since #2316 was merged, the PR needs to be changed. Which I've now donw in #2579 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.