Add Scrutinizer-CI to the build pipeline #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malukenho
commented
Jun 29, 2017
•
- Add badges to the README
fb7f4a5 to
f2c8e0b
Compare
f2c8e0b to
8748bb0
Compare
lcobucci
reviewed
Jun 29, 2017
| filter: | ||
| excluded_paths: | ||
| - docs | ||
| - tools |
There was a problem hiding this comment.
This folder doesn't exist here
| @@ -112,6 +112,9 @@ matrix: | |||
| allow_failures: | |||
| - php: nightly | |||
|
|
|||
| after_script: | |||
| - sh .travis.coverage.sh | |||
There was a problem hiding this comment.
I'd rather keep the config here so we won't have to maintain multiple files (kind of what we have in the ORM)
| @@ -0,0 +1,5 @@ | |||
| set -x | |||
| if [ "$TRAVIS_PHP_VERSION" = '7.1' ] ; then | |||
There was a problem hiding this comment.
This will run the code for ALL PHP 7.1 builds, it would be better to have it only for specific platform as well.
| set -x | ||
| if [ "$TRAVIS_PHP_VERSION" = '7.1' ] ; then | ||
| wget https://scrutinizer-ci.com/ocular.phar | ||
| php ocular.phar code-coverage:upload --format=php-clover ./clover.xml |
There was a problem hiding this comment.
clover.xml will not be magically generated, we need to pass the flags to PHPUnit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.