Fix CREATE/DROP DATABASE support on SQL Server
#2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deeky666 given that this changes behavior of the platform, wouldn't it better to push it to |
|
Merging to |
|
@Ocramius well in my opinion it is a bug because the the platform does implement all that is necessary (the create/drop SQL) but does not tell the client that this feature is supported. I don't care really, but it will make impossible to test without explicitly creating the database before testing or creating a fresh database via ORM's schema tool. |
CREATE/DROP DATABASE support on SQL Server
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is actually possible to use
CREATE DATABASEandDROP DATABASEon SQL Server. The platform did not reflect that. The issue arised when testing SQL Server where the testsuite failed, if the database used by the testsuite didn't exist. With this patch, it works as expected.