Correct SchemaManagerFunctionalTestCase::testDropsDatabaseWithActiveConnections() on OracleDB
#2254
Conversation
| @@ -51,10 +52,19 @@ public function testDropsDatabaseWithActiveConnections() | |||
|
|
|||
| $this->_sm->dropAndCreateDatabase('test_drop_database'); | |||
|
|
|||
| $this->assertContains('test_drop_database', $this->_sm->listDatabases()); | |||
| $knownDatabases = $this->_sm->listDatabases(); | |||
| if ($this->_conn->getDatabasePlatform() instanceof OraclePlatform) { | |||
There was a problem hiding this comment.
This indicates a separate issue inside the OraclePlatform IMO. Shouldn't the uppercase conversion happen in there, if upper case is enforced?
There was a problem hiding this comment.
well - the table name is uppercased and all tables are returned uppercase - on the api usage side I see no way to know if upper or lowercase is expected.
but maybe I'm not deep enough in this oracle fun 🙊
There was a problem hiding this comment.
@Ocramius where do we want to go with this? I'm open for any alternative approarch - let me know ... THX
There was a problem hiding this comment.
I think this is acceptable, given your feedback. /cc @deeky666
There was a problem hiding this comment.
@deeky666 do you agree? Can we merge this? THX
ping
Fix SchemaManagerFunctionalTestCase::testDropsDatabaseWithActiveConnections() on Oracle
|
The identifier casing issue is not only related to Oracle but I will merge this as is for now. Thanks @DeepDiver1975 ! |
SchemaManagerFunctionalTestCase::testDropsDatabaseWithActiveConnections() on OracleDB
fixes #2253