feat: add rules for trailing commas in function calls and closure use
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c1511b to
e21e534
Compare
1e3c90e to
33cca2c
Compare
Ocramius
suggested changes
Jul 8, 2022
Comment on lines
132
to
+133
| - "7.2" | ||
| - "7.3" |
There was a problem hiding this comment.
Do we still need these? They are EOL and abandoned
There was a problem hiding this comment.
Maintenance is kind of burden. I basically have to patch test inputs and outputs for each php version so I can add tests for new sniffs.
There was a problem hiding this comment.
Heh, I was suggesting to drop support overall
There was a problem hiding this comment.
Yup, that was an agreement from my side :D
but as discussed #268 (comment)
ostrolucky
approved these changes
Jul 8, 2022
Ocramius
approved these changes
Jul 8, 2022
derrabus
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #268 the same way for calls and
use