Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude classes with #[Document] attribute from container #876

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jan 6, 2025

Related to symfony/symfony#59280

Avoids any problems if the src/Document directory is not excluded from the container configuration. This directory is not excluded by default by the Symfony recipe.

@GromNaN GromNaN changed the title Exclude classes with `#[Document] attribute from container Exclude classes with #[Document] attribute from container Jan 6, 2025
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be seen as a bug, so my guess is that the 5.2.x branch is the right choice, but I'd like a second reviewer about that.

@GromNaN GromNaN requested a review from jmikola January 10, 2025 20:52
@GromNaN
Copy link
Member Author

GromNaN commented Jan 10, 2025

In my opinion, this is a new feature that simplifies configuration.

@GromNaN GromNaN added this to the 5.2.0 milestone Jan 10, 2025
@GromNaN GromNaN merged commit 783d281 into doctrine:5.2.x Jan 10, 2025
12 checks passed
@GromNaN GromNaN deleted the exclude-document-dto branch January 10, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants