Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of docpad-plugin-cssmin #6

Merged
merged 1 commit into from
Dec 12, 2013
Merged

Allow use of docpad-plugin-cssmin #6

merged 1 commit into from
Dec 12, 2013

Conversation

RobLoach
Copy link
Contributor

@RobLoach RobLoach commented Dec 6, 2013

@balupton
Copy link
Member

Awesome, will merge it in.

I wonder though, could there be a better solution to this problem? As with something like this, we'd have to add support for the cssmin extension to every pre-processor plugin.

balupton added a commit that referenced this pull request Dec 12, 2013
Allow use of docpad-plugin-cssmin
@balupton balupton merged commit 2732123 into docpad:master Dec 12, 2013
balupton added a commit that referenced this pull request Dec 12, 2013
- v2.3.0 December 12, 2013
	- Added support for `cssmin` plugin
		- Thanks to [Rob Loach](https://github.com/RobLoach) for [pull
request #6](#6)
	- Repackaged
	- Dependency upgrades
		-  `less` from ~1.4.2 to ~1.5.1
@RobLoach
Copy link
Contributor Author

Yeah, I think a better way around it would be to check for .css and completely avoid the need for the .cssmin extension. Uglify does something similar:
https://github.com/docpad/docpad-plugin-uglify/blob/master/src/uglify.plugin.coffee#L29

Either way, it won't really affect docpad-plugin-less. Thanks.

@RobLoach RobLoach deleted the add-cssmin branch December 13, 2013 00:34
@balupton
Copy link
Member

This could also be solved by naming the file: style.css.cssmin.css.less

@RobLoach
Copy link
Contributor Author

docpad-plugin-cssmin now acts on final .css files rather than using the .css.cssmin convention. We no longer need this, so I've opened up a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants