Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to LESS 2.4.0 #15

Closed
wants to merge 1 commit into from
Closed

Update to LESS 2.4.0 #15

wants to merge 1 commit into from

Conversation

RobLoach
Copy link
Contributor

No description provided.

RobLoach
RobLoach reviewed Feb 22, 2015
View reviewed changes
src/less.plugin.coffee
compileOptions[key] = value for own key,value of config.compileOptions if config.compileOptions

# Compile
opts.content = tree.toCSS(compileOptions)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need this tree.toCSS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change needed? It may be necessary to enable/disable compression

@balupton
Copy link
Member

balupton commented Mar 5, 2015

Are the comments here because of lesscss API changes?

@RobLoach
Copy link
Contributor Author

@balupton The comments I made? Was reviewing my own code.

@derberg
Copy link

derberg commented Jan 5, 2016

Hi guys, any news about this pull request? why it is not merged yet? these errors on travis do not provide any explanation

@balupton
Copy link
Member

@derberg posted up some follow up questions for @RobLoach

Ideally, I'd have this below feature from https://bevry.me/patreon done before working on more plugins:

Abstract out the powerful DocPad Plugin System into its own Independent Plugin System.
This means taking the powerful and time-tested DocPad Plugin architecture, and abstracting it out into an independent system that can be used for any project to implement it's own plugin system easily. Existing functionality allows plugins to listen to events that can even be asynchronous which are executed safely an in prioritised order either in parallel or serially by the mediator's choosing. New features will include semantic versioning support for plugins, as well as automatic installation of the correct plugin version for your existing peer dependencies.

@balupton
Copy link
Member

added in the now released v2.5.0

@balupton balupton closed this Mar 29, 2017
@balupton balupton deleted the update-less branch April 4, 2017 13:06
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobLoach @balupton @derberg