Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for source maps #10

Closed
dimitarkolev opened this issue Jan 14, 2014 · 2 comments
Closed

Add support for source maps #10

dimitarkolev opened this issue Jan 14, 2014 · 2 comments

Comments

@dimitarkolev
Copy link

It will be great if there is simple configuration for source maps. From this article it seems that its not hard thing to do: http://roots.io/using-less-source-maps/
But it cant be done with current compileOptions because one of the options is dependent to the file itself.

@paulradzkov
Copy link

+1 for source maps

balupton added a commit that referenced this issue Mar 28, 2017
Changes from @sdomagala work on this:

- remove `/docs` as there are no docs for this plugin
- update base files to latest conventions
- linting fixes, including spaces to tabs
- re-added the history to `HISTORY.md`
- removed `docpad` from `engines` as it is in `peerDependencies` which
is the new place
- moved from `import` to `require` so the source can run on node
- moved from `Object.assign` to `extendr` - docpad already uses extendr
so this reduces complexity
- update editions for latest standard and correct syntax
- removed superfluous dev dependencies
- fixed plugin configuration not being used - should be `get
initialConfig` for ES6 classes
- `paths` option was not an array when it should be, now fixed
- the `Object.assign` was writing to the wrong object, as it should be
updating `parseOptions` to send to the render
- made the `compress` option useful again, as it became useless when
`compileOptions` was removed
- added source maps #10
- added ability to disable referencesOthers #12
- added tests to show the importance of referencesOthers, source maps,
and compression

Still todo:

- This should probably be merged into master via a squash merge, to
avoid comitting things that were not needed
- Also need to determine if the renames for the coffeescript to esnext
occurred correctly such that history is preserved

Thanks everyone for your assistance on this. Greatly appreciated and
well done.
balupton added a commit that referenced this issue Mar 29, 2017
Merges in the v2.5.0 changes into the current master:
https://github.com/docpad/docpad-plugin-less/tree/8ee72b49e0bd2787b12eb408481ee55251fb0e25

Squash merge to avoid comitting things that were not needed.

@sdomagala's work:

- less v1.6 to v2.6 upgrade
- coffeescript to esnext conversion
- update base files

@balupton's modifications:

- remove `/docs` as there are no docs for this plugin
- update base files to latest conventions
- linting fixes, including spaces to tabs
- re-added the history to `HISTORY.md`
- removed `docpad` from `engines` as it is in `peerDependencies` which
is the new place
- moved from `import` to `require` so the source can run on node
- moved from `Object.assign` to `extendr` - docpad already uses extendr
so this reduces complexity
- update editions for latest standard and correct syntax
- removed superfluous dev dependencies
- fixed plugin configuration not being used - should be `get
initialConfig` for ES6 classes
- `paths` option was not an array when it should be, now fixed
- the `Object.assign` was writing to the wrong object, as it should be
updating `parseOptions` to send to the render
- made the `compress` option useful again, as it became useless when
`compileOptions` was removed
- added source maps #10
- added ability to disable referencesOthers #12
- added tests to show the importance of referencesOthers, source maps,
and compression
- disable source maps for tests as the results will always be different

Thanks everyone for your assistance on this. Greatly appreciated and
well done.
@balupton
Copy link
Member

added in the now released v2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants