Feature/wdl launch and convert fix #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elative paths from primary descriptor
Codecov Report
@@ Coverage Diff @@
## develop #1611 +/- ##
=============================================
- Coverage 68.26% 64.36% -3.91%
Complexity 11 11
=============================================
Files 167 167
Lines 12201 12925 +724
Branches 1642 1844 +202
=============================================
- Hits 8329 8319 -10
- Misses 3155 3886 +731
- Partials 717 720 +3
Continue to review full report at Codecov.
|
agduncan94
approved these changes
Jul 16, 2018
garyluu
reviewed
Jul 16, 2018
| import org.junit.rules.ExpectedException; | ||
|
|
||
| /** | ||
| * Basic confidential integration tests, focusing on publishing/unpublishing both automatic and manually added tools |
| out(""); | ||
| out("Optional parameters:"); | ||
| out(" --json <json file> Parameters to the entry in the dockstore, one map for one run, an array of maps for multiple runs"); | ||
| out(" --yaml <yaml file> Parameters to the entry in the dockstore, one map for one run, an array of maps for multiple runs (Only for CWL)"); | ||
| out(" --tsv <tsv file> One row corresponds to parameters for one run in the dockstore (Only for CWL)"); | ||
| out(" --descriptor <descriptor type> Descriptor type used to launch workflow. Defaults to " + CWL_STRING); | ||
| out(" --local-entry Allows you to specify a full path to a local descriptor for --entry instead of an entry path"); | ||
| if (!(this instanceof CheckerClient)) { | ||
| out(" --local-entry Allows you to specify a full path to a local descriptor for --entry instead of an entry path"); |
There was a problem hiding this comment.
when this is not a checker client, does it display --local-entry as a possible required parameter (OR) and also an optional parameter?
There was a problem hiding this comment.
This just maintains the current behavior which is to display it in both places.
It does seem a bit odd, will create follow-up item to clean up these descriptions
#1612
garyluu
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #1549 and #1474
Allow Cromwell to run from the working directory of the downloaded descriptors as opposed to the current working directory (as opposed to re-writing imports to match working directory).