added {http,https,no} proxy support to docker engines

[udryan10]

Adds HTTP_PROXY, HTTPS_PROXY and NO_PROXY support to docker engines per issue #1319

[nathanleclaire]

Hm, cool, thanks for the contribution.

I'm wondering if it might be better to have just one flag, which will then apply to any environment variable, instead of three (and possibly more in the future) different flags?

That way, you would :

$ docker-machine create -d provider --engine-env HTTP_PROXY=http://foo.com --engine-env HTTPS_PROXY=bar.com proxybox

What do you think?

[udryan10]

@nathanleclaire I like it! I'll update the PR.

[udryan10]

@nathanleclaire the PR now has code that implements the more general --engine-env flag

[nathanleclaire]

Very cool. Any ideas how to test this in the integration suite?

[udryan10]

@nathanleclaire I came up with a test that should work well -- spins up a machine and checks /proc/<docker daemon pid>/environs for the set Environment Variable. Let me know what you think.

[ehazlett]

👍 for this -- i know a lot will benefit :)

[nathanleclaire]

Looking pretty good --- we are about to merge in some structural changes to our docs, I will need you to rebase after that and then we will be ready to rock. I'll ping you when it's ready to rebase.

[nathanleclaire]

OK I've merged that docs PR -- please rebase when it is convenient for you. Thanks!

[udryan10]

@nathanleclaire I have rebased my doc changes into the new doc structure

[nathanleclaire]

I'm not sure this is supposed to be here?

[nathanleclaire]

cc @ehazlett for review of this PR

[udryan10]

@nathanleclaire fixed up the mistake in the docs/reference/create.md you referenced - apologies for that oversight.

[nathanleclaire]

Thanks @udryan10 and no problem.

Hey @tianon, could you please take a quick look at these changes to the various OS configurations and note if anything strikes you as incorrect? For instance, I'm not sure if we should do export VAR=blah in /var/lib/boot2docker/profile, the rest of environment variables set there are not exported.

[nathanleclaire]

Heh... this is HTTPS_PROXY but the proto specified is http ;D

[tianon]

It all looks reasonably sane, but what happens when I need quotes in my environment variable values? ie: --engine-env SOME_VAR='some "value" ' (which will come through into Go as "SOME_VAR=some \"value\" ")

[tianon]

(ie, we probably ought to pass these through %q from fmt at the very least)

[udryan10]

I've updated the code to run the env's through %q

[ehazlett]

LGTM

[nathanleclaire]

LGTM

[chadswen]

It seems that some aspect of proxy variable parsing can be picky about the proxy URL schema. I was getting "Proxy Authentication" errors with a proxy that doesn't require credentials. Adding a trailing slash to my proxy variables fixed the issue, as in:

docker-machine create -d virtualbox \
    --engine-env HTTP_PROXY=http://example.com:8080/ \
    --engine-env HTTPS_PROXY=https://example.com:8080/ \
    default

This format is used in the Docker Engine example, but it's not used in the docker-machine create example.

[nathanleclaire]

@chadswen Could I get you to file a new issue about the documentation change required and cc @udryan10 and myself please? Thanks!