Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 186 #204

Closed
wants to merge 3 commits into from
Closed

Fix 186 #204

wants to merge 3 commits into from

Conversation

converge
Copy link
Contributor

- What I did

As reported on #186, user token deletion is failing to delete user access tokens. The issue is caused by the missing username at the hubClient.AuthConfig.Username struct field, the confirmation step looks for the username to confirm, but the username information is empty/not set.

- How I did it

At initialization, the auth, err := store.GetAuth() is called, I got it in advance, and provided the authorization data to the struct.

- How to verify it

  1. create a new user token via hub-tool token create
  2. delete the user token via hub-tool token rm uuid-token
  3. the confirmation step will now show the username, and the username can be confirmed.

- Description for the changelog

Fix user token deletion by adding missing authorization data to the hubClient.

- A picture of a cute animal (not mandatory)

thinkst-marco and others added 3 commits September 16, 2021 16:25
Signed-off-by: Marco Slaviero <marco@thinkst.com>
Signed-off-by: João Vanzuita <joaovanzuita@me.com>
@converge converge closed this Apr 12, 2022
@converge converge deleted the fix_186 branch April 12, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants