Fix typo on env vars #108
Merged
Fix typo on env vars #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-crone
reviewed
Nov 6, 2020
internal/hub/instances.go
Outdated
| @@ -43,7 +43,7 @@ var ( | |||
| // getInstance returns the current hub instance, which can be overridden by | |||
| // DOCKER_REGISTRY_URL and DOCKER_REGISTRY_URL env var | |||
| func getInstance() *Instance { | |||
| apiBaseURL := os.Getenv("DOCKER_REGISTRY_URL") | |||
| apiBaseURL := os.Getenv("DOCKER_API_URL") | |||
There was a problem hiding this comment.
In case we have another Docker something API:
Suggested change
| apiBaseURL := os.Getenv("DOCKER_API_URL") | |
| apiBaseURL := os.Getenv("DOCKER_HUB_API_URL") |
…d DOCKER_HUB_API_URL Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
6996c33 to
8e77ceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo, we should have 2 different env vars: DOCKER_REGISTRY_URL and DOCKER_API_URL