Drop packaging dependency

[akx]

It doesn't seem to be required.

Implement the same version comparison algorithm Moby uses instead.

[milas]

packaging.Version is used in docker/utils/utils.py:

docker-py/docker/utils/utils.py

Lines 58 to 59 in f467fd9

	s1 = Version(v1)
	s2 = Version(v2)

That was changed from distutils.Version:

• Use packaging instead of distutils for Version #2931

I'm happy to get rid of the dependency, especially given the small surface area. Do you have a suggested alternative?

[akx]

packaging.Version is used in docker/utils/utils.py:

Ah, sorry, yeah, good catch.

Do you have a suggested alternative?

How are Docker versions specified? packaging.Version is, after all, meant to parse Python version specifiers, not versions in general...

If they're specified to be just A.B[.C] where each part is an integer, then it's trivial to split, cast to integers in a tuple and compare them :)

[milas]

If they're specified to be just A.B[.C] where each part is an integer, then it's trivial to split, cast to integers in a tuple and compare them :)

Yep, that's effectively what Moby does: https://github.com/moby/moby/blob/e7001c14558af124d7959c1d1cfe3a16b507c521/api/types/versions/compare.go#L8-L40

(Technically there can be an arbitrary number of version sections; in practice, I hope we never make an API version 1.2.3.4.5.6.7.8.9.0 😛)

[akx]

@milas Great :) Rebased, implemented the same algorithm here, added tests.

[milas]

LGTM and 😲 with that turn-around time 🎉