Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default API version to 1.43 (Moby 24.0) #3199

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Bump default API version to 1.43 (Moby 24.0) #3199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
TEST_API_VERSION ?= 1.41
TEST_ENGINE_VERSION ?= 20.10
TEST_API_VERSION ?= 1.43
TEST_ENGINE_VERSION ?= 24.0

ifeq ($(OS),Windows_NT)
PLATFORM := Windows
Expand Down
2 changes: 1 addition & 1 deletion docker/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import sys
from .version import __version__

DEFAULT_DOCKER_API_VERSION = '1.41'
DEFAULT_DOCKER_API_VERSION = '1.43'
MINIMUM_DOCKER_API_VERSION = '1.21'
Copy link
Member

@thaJeztah thaJeztah Dec 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also start looking at raising this minimum, but I don't know if there's code specific in docker-py that handles differences between versions @milas ?

We're starting to deprecate old API versions, and the initial step is to disable (by default) API versions < 1.24. API 1.24 is the last version of the API before introduction of API version negotiation, so that's the version the CLI falls back to if it's unable to negotiate.

DEFAULT_TIMEOUT_SECONDS = 60
STREAM_HEADER_SIZE_BYTES = 8
Expand Down
4 changes: 2 additions & 2 deletions tests/Dockerfile-ssh-dind
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax=docker/dockerfile:1

ARG API_VERSION=1.41
ARG ENGINE_VERSION=20.10
ARG API_VERSION=1.43
ARG ENGINE_VERSION=24.0

FROM docker:${ENGINE_VERSION}-dind

Expand Down