Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not a Contribution: create_api_error_from_api_exception should "raise <exception> from <original-error>" to preserve error message #2702

Closed
anorth2 opened this issue Nov 18, 2020 · 0 comments · Fixed by #3023
Closed

Not a Contribution: create_api_error_from_api_exception should "raise <exception> from <original-error>" to preserve error message #2702

anorth2 opened this issue Nov 18, 2020 · 0 comments · Fixed by #3023

Comments

@anorth2
Copy link

anorth2 commented Nov 18, 2020 •
edited
Loading

Not a Contribution.

APIError handling should be changed to so that it doesn't hide the original exception.

https://stackoverflow.com/questions/24752395/python-raise-from-usage
@anorth2 anorth2 changed the title create_api_error_from_api_exception should "raise <exception> from <original-error>" to preserve error message Not a Contribution: create_api_error_from_api_exception should "raise <exception> from <original-error>" to preserve error message Nov 18, 2020
milas added a commit to milas/docker-py that referenced this issue Jul 28, 2022
@milas
api: preserve cause when re-raising error
292b423 
Use `from e` to ensure that the error context is propagated
correctly.

Fixes docker#2702.
@milas milas mentioned this issue Jul 28, 2022
Merged
milas added a commit to milas/docker-py that referenced this issue Jul 29, 2022
@milas
api: preserve cause when re-raising error
4169226 
Use `from e` to ensure that the error context is propagated
correctly.

Fixes docker#2702.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas added a commit that referenced this issue Jul 29, 2022
@milas
api: preserve cause when re-raising error (#3023)
05e1434 
Use `from e` to ensure that the error context is propagated
correctly.

Fixes #2702.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: preserve cause when re-raising error milas/docker-py
1 participant
@anorth2