Skip to content

Commit

Permalink
ssh: do not create unnecessary subshell on exec (#2910)
Browse files Browse the repository at this point in the history
Signed-off-by: liubo <liubo@uniontech.com>
  • Loading branch information
errorcode7 authored Jul 27, 2022
1 parent 52e29bd commit bb40ba0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions docker/transport/sshconn.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@ def f():
env.pop('SSL_CERT_FILE', None)

self.proc = subprocess.Popen(
' '.join(args),
args,
env=env,
shell=True,
stdout=subprocess.PIPE,
stdin=subprocess.PIPE,
preexec_fn=None if constants.IS_WINDOWS_PLATFORM else preexec_func)
Expand Down

0 comments on commit bb40ba0

Please sign in to comment.