Skip to content

Commit

Permalink
lint: fix deprecation warnings from threading package (#2823)
Browse files Browse the repository at this point in the history
Set `daemon` attribute instead of using `setDaemon` method that
was deprecated in Python 3.10.

Signed-off-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
  • Loading branch information
tirkarthi authored Jul 27, 2022
1 parent d929864 commit adf5a97
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tests/integration/api_image_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ def do_GET(self):

server = socketserver.TCPServer(('', 0), Handler)
thread = threading.Thread(target=server.serve_forever)
thread.setDaemon(True)
thread.daemon = True
thread.start()

yield f'http://{socket.gethostname()}:{server.server_address[1]}'
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/api_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ def setUp(self):
self.server_socket = self._setup_socket()
self.stop_server = False
server_thread = threading.Thread(target=self.run_server)
server_thread.setDaemon(True)
server_thread.daemon = True
server_thread.start()
self.response = None
self.request_handler = None
Expand Down Expand Up @@ -488,7 +488,7 @@ def setup_class(cls):
cls.server = socketserver.ThreadingTCPServer(
('', 0), cls.get_handler_class())
cls.thread = threading.Thread(target=cls.server.serve_forever)
cls.thread.setDaemon(True)
cls.thread.daemon = True
cls.thread.start()
cls.address = 'http://{}:{}'.format(
socket.gethostname(), cls.server.server_address[1])
Expand Down

0 comments on commit adf5a97

Please sign in to comment.