-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test stage and ci jobs #224
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=========================================
Coverage ? 51.13%
=========================================
Files ? 9
Lines ? 659
Branches ? 0
=========================================
Hits ? 337
Misses ? 286
Partials ? 36 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
||
```shell | ||
# create builder | ||
$ docker buildx create --use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this require a container builder? If it's just single arch, it should work without, I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes required because we are building against multi-platforms (osxkeychain, wincred, pass)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, right, it's building all of them
what's the easiest way to build only one?
|
||
The programs in this repository are written with the Go programming language. These instructions assume that you have previous knowledge about the language and you have it installed in your machine. | ||
Or if the toolchain is already installed on your machine: | ||
|
||
1 - Download the source and put it in your `$GOPATH` with `go get`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this section is in need of a rewrite as well (go get
won't work anymore to clone the repository)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes if we bump to Go 1.19 this has to be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prepared #226 for go 1.18 (but best to do after this one)
ea3e129
to
1a03d8d
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
follow-up #209
Tests run on specific runners with respect to the target OS and the results are merged and sent to Codecov. Containerized tests are only available for host platform atm (that's why a specific job has been added in the build workflow).
cc @thaJeztah