Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: update to go 1.16, and fix selection of ppc64le #204

Closed
wants to merge 2 commits into from

Conversation

thaJeztah
Copy link
Member

let's see if this fixes CI

@thaJeztah
Copy link
Member Author

Ah, interesting;

$ make validate
$ make test
# tests all packages except vendor
go test -v `go list ./... | grep -v /vendor/`
client/command.go:8:2: missing go.sum entry for module providing package golang.org/x/sys/execabs (imported by github.com/docker/docker-credential-helpers/client); to add:
	go get github.com/docker/docker-credential-helpers/client
make: *** [test] Error 1
The command "make test" exited with 2.

@thaJeztah
Copy link
Member Author

no dice; issue with go1.16?

go test -v `go list ./... | grep -v /vendor/`
# github.com/docker/docker-credential-helpers/secretservice.test
/home/travis/.gimme/versions/go1.16.4.linux.amd64/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: /tmp/go-link-383734037/000006.o: unrecognized relocation (0x2a) in section `.text'
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status

@thaJeztah
Copy link
Member Author

Hmm updating to focal (ubunu 20.10) of course also requires systemd to be used, which CI doesn't like to be running;

+systemctl start Xvfb.service
==== AUTHENTICATING FOR org.freedesktop.systemd1.manage-units ===
Authentication is required to start 'Xvfb.service'.
Authenticating as: root
Password: Failed to start Xvfb.service: Connection timed out
See system logs and 'systemctl status Xvfb.service' for details.
polkit-agent-helper-1: pam_authenticate failed: Authentication failure
The command "if [[ "$TRAVIS_OS_NAME" == "linux" && "$HOSTTYPE" != "ppc64le" ]]; then sh ci/before_script_linux.sh; fi" failed and exited with 1 during .

@thaJeztah thaJeztah force-pushed the fix_ci branch 5 times, most recently from 26792a9 to da1b395 Compare June 1, 2021 08:23
@thaJeztah
Copy link
Member Author

Hm.. looks like pass is failing with gpg2 (perhaps still something wrong with how it's initialised)

ok  	github.com/docker/docker-credential-helpers/credentials	0.006s
=== RUN   TestPassHelper
    pass_test.go:26: no usernames for https://foobar.docker.io:2376/v1
--- FAIL: TestPassHelper (0.10s)

thaJeztah added 2 commits June 1, 2021 13:36
Focal uses systemd, so using the instructions from the travis documentation at
https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-xvfb-to-run-tests-that-require-a-gui
to start xvfb.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This requires a more recent version of gcc to compile, otherwise compile is failing:

    go test -v `go list ./... | grep -v /vendor/`
    # github.com/docker/docker-credential-helpers/secretservice.test
    /home/travis/.gimme/versions/go1.16.4.linux.amd64/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
    /usr/bin/ld: /tmp/go-link-383734037/000006.o: unrecognized relocation (0x2a) in section `.text'
    /usr/bin/ld: final link failed: Bad value
    collect2: error: ld returned 1 exit status

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant